Fixed an issue with Geography.point method having coordinates reversed#853
Merged
peterbae merged 6 commits intomicrosoft:devfrom Nov 28, 2018
Merged
Fixed an issue with Geography.point method having coordinates reversed#853peterbae merged 6 commits intomicrosoft:devfrom
peterbae merged 6 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #853 +/- ##
============================================
+ Coverage 48.71% 48.72% +0.01%
- Complexity 2796 2815 +19
============================================
Files 116 118 +2
Lines 27877 27867 -10
Branches 4650 4639 -11
============================================
Hits 13579 13579
- Misses 12091 12092 +1
+ Partials 2207 2196 -11
Continue to review full report at Codecov.
|
lilgreenbird
previously approved these changes
Oct 26, 2018
rene-ye
previously approved these changes
Oct 26, 2018
cheenamalhotra
previously approved these changes
Nov 20, 2018
peterbae
dismissed stale reviews from cheenamalhotra, rene-ye, and lilgreenbird
via
093783d
rene-ye
previously approved these changes
Nov 23, 2018
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 28, 2018
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java
Outdated
Show resolved
Hide resolved
ulvii
approved these changes
Nov 28, 2018
cheenamalhotra
approved these changes
Nov 28, 2018
peterbae
changed the title
ulvii
changed the title
ulvii
pushed a commit
that referenced
this pull request
Nov 30, 2018
Fix | Fixes Geography.point method to expected behavior (#853)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #851.
According to this page, Geography::point method has the coordinates reversed (lat, long instead of the usual long, lat) compared to the other methods of inserting a Geography point. This PR aligns the driver behavior with the expected behavior.